commit eb960f40b174d8bd8e1ed05273e9aa4fe663e9d9
author Ruiling Song <ruiling.song@intel.com> Mon Jul 29 16:32:32 2019 +0800
committer Yaowu Xu <yaowu@google.com> Mon Jul 29 15:52:55 2019 +0000
tree e3ccf1d5c818f1fb88a25de0e928e36f999f83e7
parent c03d327e5b453fcc8148dcd81eb1f42ed5b086e4

Remove unnecessary initialization

I double check the original issue, and find the root-cause of reading
uninitialized memory was caused by loading extra 2-taps when doing 10-taps
vfilter(). now that we only have 8 taps here, the initialization is
not needed anymore. Just remove it.

Change-Id: Id6fb9acd8fb96fc07c18c00b1a9cdae069f139b1

av1/common/x86/av1_convolve_scale_sse4.c

diff --git a/av1/common/x86/av1_convolve_scale_sse4.c b/av1/common/x86/av1_convolve_scale_sse4.c
index 8f44238..b4b76e0 100644
--- a/av1/common/x86/av1_convolve_scale_sse4.c
+++ b/av1/common/x86/av1_convolve_scale_sse4.c
@@ -236,8 +236,7 @@
                                   const int subpel_x_qn, const int x_step_qn,
                                   const int subpel_y_qn, const int y_step_qn,
                                   ConvolveParams *conv_params) {
-  // TODO(yaowu): remove unnecessary initializations
-  int16_t tmp[(2 * MAX_SB_SIZE + MAX_FILTER_TAP) * MAX_SB_SIZE] = { 0 };
+  int16_t tmp[(2 * MAX_SB_SIZE + MAX_FILTER_TAP) * MAX_SB_SIZE];
   int im_h = (((h - 1) * y_step_qn + subpel_y_qn) >> SCALE_SUBPEL_BITS) +
              filter_params_y->taps;