commit ef8e0492c5ae2c555f0237ede877580283832542
author James Zern <jzern@google.com> Fri Sep 02 15:53:04 2022 -0700
committer James Zern <jzern@google.com> Tue Sep 06 20:20:36 2022 +0000
tree 8bb36d121eef5df76d0f12a9cec6dc12f650d422
parent 7d9347a17e0cbdd5dbb1e67de88bce07b41a2d80

sad_neon.c: simplify __ARM_FEATURE_DOTPROD check

only check that the macro is defined, the value doesn't have any effect.

from https://arm-software.github.io/acle/main/acle.html:

5.5.7.7.  Dot Product extension
  __ARM_FEATURE_DOTPROD is defined if the dot product data manipulation
  instructions are supported and the vector intrinsics are available.
  Note that this implies:
    - __ARM_NEON == 1

Change-Id: I164fe121ccefda99050a9b6a99738a2b518520f3

aom_dsp/arm/sad_neon.c

diff --git a/aom_dsp/arm/sad_neon.c b/aom_dsp/arm/sad_neon.c
index 946d8f9..47e0045 100644
--- a/aom_dsp/arm/sad_neon.c
+++ b/aom_dsp/arm/sad_neon.c
@@ -15,7 +15,7 @@
 #include "aom/aom_integer.h"
 #include "aom_dsp/arm/sum_neon.h"
 
-#if defined(__ARM_FEATURE_DOTPROD) && (__ARM_FEATURE_DOTPROD == 1)
+#if defined(__ARM_FEATURE_DOTPROD)
 
 static INLINE unsigned int sadwxh_neon(const uint8_t *src_ptr, int src_stride,
                                        const uint8_t *ref_ptr, int ref_stride,
@@ -99,7 +99,7 @@
   return horizontal_add_u32x4(vaddq_u32(sum[0], sum[1]));
 }
 
-#else
+#else  // !defined(__ARM_FEATURE_DOTPROD)
 
 static INLINE unsigned int sad128xh_neon(const uint8_t *src_ptr, int src_stride,
                                          const uint8_t *ref_ptr, int ref_stride,
@@ -267,7 +267,7 @@
   return horizontal_add_u16x8(sum);
 }
 
-#endif
+#endif  // defined(__ARM_FEATURE_DOTPROD)
 
 static INLINE unsigned int sad8xh_neon(const uint8_t *src_ptr, int src_stride,
                                        const uint8_t *ref_ptr, int ref_stride,