commit eff4794dad7abc49621795d0561deb7548baa229
author chiyotsai <chiyotsai@google.com> Mon Jul 22 11:50:32 2019 -0700
committer Chi Yo Tsai <chiyotsai@google.com> Tue Jul 23 23:47:03 2019 +0000
tree e7f965d1bf8b1289c0a719a048bb4ce924627e5e
parent 4a57c94fe6a26e269494f0879c231bf2a6cb1313

Fix condition to try ext partitions

The extended partition should only be used when no more than half of the
current block is outside of the available image. Currently, the codebase
tests this condition with partition_none_allowed, which can be modified
by various speed features. Instead, the condition should be tested with
has_rows && has_cols.

Change-Id: I2e11730d586b9e746537ed3411afd908e08f7915

av1/encoder/encodeframe.c

diff --git a/av1/encoder/encodeframe.c b/av1/encoder/encodeframe.c
index b5a8b1d..06f6444 100644
--- a/av1/encoder/encodeframe.c
+++ b/av1/encoder/encodeframe.c
@@ -2990,7 +2990,7 @@
   assert(IMPLIES(!cpi->oxcf.enable_rect_partitions, !do_rectangular_split));
 
   const int ext_partition_allowed =
-      do_rectangular_split && bsize > BLOCK_8X8 && partition_none_allowed;
+      do_rectangular_split && bsize > BLOCK_8X8 && has_rows && has_cols;
 
   // The standard AB partitions are allowed whenever ext-partition-types are
   // allowed