commit 23d7790ffb962ffba38e44509072a452355567e1
author Vincent Rabaud <vrabaud@google.com> Fri Aug 30 12:54:42 2024 +0200
committer GitHub <noreply@github.com> Fri Aug 30 12:54:42 2024 +0200
tree 22e30d93f08727ae3dc26af591974e3672c64291
parent 984244e152078aed5e15074c9743eff9e703a12c

Compile avif_fuzztest_helpers.cc only once. (#2417)

tests/CMakeLists.txt

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 90c9aac..da1b0f9 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -186,9 +186,9 @@
     # Adds a fuzztest from file TEST_NAME.cc located in the gtest folder. Extra arguments
     # are considered as extra source files.
     macro(add_avif_fuzztest TEST_NAME)
-        add_executable(${TEST_NAME} gtest/${TEST_NAME}.cc gtest/avif_fuzztest_helpers.cc ${ARGN})
+        add_executable(${TEST_NAME} gtest/${TEST_NAME}.cc ${ARGN})
         # FuzzTest bundles GoogleTest so no need to link to gtest librairies.
-        target_link_libraries(${TEST_NAME} PRIVATE aviftest_helpers_internal avif_enable_warnings)
+        target_link_libraries(${TEST_NAME} PRIVATE avif_fuzztest_helpers aviftest_helpers_internal avif_enable_warnings)
         link_fuzztest(${TEST_NAME})
         add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME})
         set_property(TEST ${TEST_NAME} PROPERTY ENVIRONMENT "TEST_DATA_DIRS=${CMAKE_CURRENT_SOURCE_DIR}/data/")
@@ -220,6 +220,11 @@
     endif()
     fuzztest_setup_fuzzing_flags()
 
+    # Create a library with avif_fuzztest_helpers.cc to compile it only once.
+    add_library(avif_fuzztest_helpers OBJECT gtest/avif_fuzztest_helpers.cc)
+    target_link_libraries(avif_fuzztest_helpers PUBLIC aviftest_helpers_internal)
+    link_fuzztest(avif_fuzztest_helpers)
+
     add_avif_fuzztest(avif_fuzztest_dec)
     add_avif_fuzztest(avif_fuzztest_dec_incr gtest/avifincrtest_helpers.cc)
     add_avif_fuzztest(avif_fuzztest_enc_dec)