commit 4475fca4d8471b4804f7cb1d62c26152f72b62ac
author Wan-Teh Chang <wtc@google.com> Fri Apr 24 10:41:34 2020 -0700
committer Joe Drago <joedrago@gmail.com> Fri Apr 24 10:59:05 2020 -0700
tree a71d3ee0d74f23ae43501d12f1f3fb0986580a6a
parent f74e1edd0c3159b15b9eb661cf1d4f53ed6f360c

Cast nclx enum type members to uint16_t

This allows me to build libavif with -Wconversion enabled except for the
warnings in cJSON.c with clang 7.0.1 and 8.0.1 due to a clang bug:
https://bugs.llvm.org/show_bug.cgi?id=35268

src/write.c

diff --git a/src/write.c b/src/write.c
index 3eead9b..205df62 100644
--- a/src/write.c
+++ b/src/write.c
@@ -399,12 +399,12 @@
 
             if (item->image->profileFormat == AVIF_PROFILE_FORMAT_NCLX) {
                 avifBoxMarker colr = avifRWStreamWriteBox(&s, "colr", -1, 0);
-                avifRWStreamWriteChars(&s, "nclx", 4);                               // unsigned int(32) colour_type;
-                avifRWStreamWriteU16(&s, item->image->nclx.colourPrimaries);         // unsigned int(16) colour_primaries;
-                avifRWStreamWriteU16(&s, item->image->nclx.transferCharacteristics); // unsigned int(16) transfer_characteristics;
-                avifRWStreamWriteU16(&s, item->image->nclx.matrixCoefficients);      // unsigned int(16) matrix_coefficients;
-                avifRWStreamWriteU8(&s, item->image->nclx.range & 0x80);             // unsigned int(1) full_range_flag;
-                                                                                     // unsigned int(7) reserved = 0;
+                avifRWStreamWriteChars(&s, "nclx", 4);                                 // unsigned int(32) colour_type;
+                avifRWStreamWriteU16(&s, (uint16_t)item->image->nclx.colourPrimaries); // unsigned int(16) colour_primaries;
+                avifRWStreamWriteU16(&s, (uint16_t)item->image->nclx.transferCharacteristics); // unsigned int(16) transfer_characteristics;
+                avifRWStreamWriteU16(&s, (uint16_t)item->image->nclx.matrixCoefficients); // unsigned int(16) matrix_coefficients;
+                avifRWStreamWriteU8(&s, item->image->nclx.range & 0x80);                  // unsigned int(1) full_range_flag;
+                                                                                          // unsigned int(7) reserved = 0;
                 avifRWStreamFinishBox(&s, colr);
                 ipmaPush(&item->ipma, ++itemPropertyIndex, AVIF_FALSE);
             } else if ((item->image->profileFormat == AVIF_PROFILE_FORMAT_ICC) && item->image->icc.data && (item->image->icc.size > 0)) {