commit 71d008eee44eec0994dafff01d296111f44fc123
author Wan-Teh Chang <wtc@google.com> Fri Sep 23 21:35:10 2022 -0700
committer Wan-Teh Chang <wtc@google.com> Mon Sep 26 10:21:26 2022 -0700
tree 4e6ad756e22a7e00168dd47f10ab528ecfdae102
parent ac58c4fb28fe4d4a6d054099c958925652271eb8

Remove assert(b != 0).

apps/shared/avifutil.c

diff --git a/apps/shared/avifutil.c b/apps/shared/avifutil.c
index 3509a42..003fd64 100644
--- a/apps/shared/avifutil.c
+++ b/apps/shared/avifutil.c
@@ -3,7 +3,6 @@
 
 #include "avifutil.h"
 
-#include <assert.h>
 #include <ctype.h>
 #include <stdio.h>
 #include <string.h>
@@ -16,22 +15,18 @@
 // overflowing int32_t.
 static int64_t calcGCD(int64_t a, int64_t b)
 {
-    assert(b != 0);
     if (a < 0) {
         a *= -1;
     }
     if (b < 0) {
         b *= -1;
     }
-    for (;;) {
+    while (b != 0) {
         int64_t r = a % b;
-        if (r == 0) {
-            break;
-        }
         a = b;
         b = r;
     }
-    return b;
+    return a;
 }
 
 static void printClapFraction(const char * name, int32_t n, int32_t d)

src/avif.c

diff --git a/src/avif.c b/src/avif.c
index 09f7f17..b17d396 100644
--- a/src/avif.c
+++ b/src/avif.c
@@ -3,7 +3,6 @@
 
 #include "avif/internal.h"
 
-#include <assert.h>
 #include <limits.h>
 #include <stdint.h>
 #include <string.h>
@@ -515,22 +514,18 @@
 // overflowing int32_t.
 static int64_t calcGCD(int64_t a, int64_t b)
 {
-    assert(b != 0);
     if (a < 0) {
         a *= -1;
     }
     if (b < 0) {
         b *= -1;
     }
-    for (;;) {
+    while (b != 0) {
         int64_t r = a % b;
-        if (r == 0) {
-            break;
-        }
         a = b;
         b = r;
     }
-    return b;
+    return a;
 }
 
 static void clapFractionSimplify(clapFraction * f)