commit 80f19024a895c48a7d637f3423245e75f29e8cbf
author James Zern <jzern@google.com> Mon Mar 10 15:47:55 2025 -0700
committer GitHub <noreply@github.com> Mon Mar 10 15:47:55 2025 -0700
tree 7bfa6f1c5819e80dbeaa155857c8e3ec4c8d2ee8
parent b57a7291af11aa5ab6beb671ec856c5062df0793

test_cmd_stdin: avoid outputting binary data to terminal (#2680)

Use `dd` rather than command substitution to avoid outputting binary
data when `set -x` is enabled. This also fixes a related warning:
  test_cmd_stdin.sh: line 43: warning: command substitution: ignored
                                       null byte in input

tests/test_cmd_stdin.sh

diff --git a/tests/test_cmd_stdin.sh b/tests/test_cmd_stdin.sh
index 8af03d9..cfd00f2 100755
--- a/tests/test_cmd_stdin.sh
+++ b/tests/test_cmd_stdin.sh
@@ -40,8 +40,8 @@
     #   awk -b -v RS='mdat' '{print length($0); exit}' "${FILE}"
     # Hence the hardcoded variable below.
     MDAT_OFFSET=1061
-    FILE_CONTENTS_AFTER_HEADER=$(tail -c +${MDAT_OFFSET} < "${FILE}")
-    echo "${FILE_CONTENTS_AFTER_HEADER}" > "${FILE}"
+    dd if="${FILE}" of="${FILE}.strip" bs=1 skip="${MDAT_OFFSET}"
+    mv "${FILE}.strip" "${FILE}"
   fi
 }