commit ad85b6291c4139f8020226852adc1b0a14452bc8
author Yannis Guyon <yguyon@google.com> Fri Mar 24 11:31:36 2023 +0100
committer Yannis Guyon <yguyon@google.com> Fri Mar 24 13:50:05 2023 +0100
tree 8e8234b24e11b39096170f276d2cacfdcca265e0
parent 129a59047ea2b31f21109b4ed07dde32662f1b4c

Fix avifImageSetViewRect() for monochrome odd xy

avifGetPixelFormatInfo() sets chromaShiftX,Y to 1 even when there is
no chroma.

src/avif.c

diff --git a/src/avif.c b/src/avif.c
index 8fa2b36..e74aba7 100644
--- a/src/avif.c
+++ b/src/avif.c
@@ -255,7 +255,10 @@
     avifPixelFormatInfo formatInfo;
     avifGetPixelFormatInfo(srcImage->yuvFormat, &formatInfo);
     if ((rect->width > srcImage->width) || (rect->height > srcImage->height) || (rect->x > (srcImage->width - rect->width)) ||
-        (rect->y > (srcImage->height - rect->height)) || (rect->x & formatInfo.chromaShiftX) || (rect->y & formatInfo.chromaShiftY)) {
+        (rect->y > (srcImage->height - rect->height))) {
+        return AVIF_RESULT_INVALID_ARGUMENT;
+    }
+    if (!formatInfo.monochrome && ((rect->x & formatInfo.chromaShiftX) || (rect->y & formatInfo.chromaShiftY))) {
         return AVIF_RESULT_INVALID_ARGUMENT;
     }
     avifImageFreePlanes(dstImage, AVIF_PLANES_ALL); // dstImage->imageOwnsYUVPlanes and dstImage->imageOwnsAlphaPlane set to AVIF_FALSE.